Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dns rust keywords 7529 v2 #12496

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

catenacyber
Copy link
Contributor

Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/7529

Describe changes:

  • dns: move keywords to rust
  • extend some dns keywords so that they can use string enumerations

#11932 next protocol
#12483 with rust warning fix and dedicated ticket

Draft : still need to craft SV tests ro replace unit tests DetectDnsQueryTest

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 94.89247% with 19 lines in your changes missing coverage. Please review.

Project coverage is 80.58%. Comparing base (53abe1e) to head (6b08c9b).
Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12496      +/-   ##
==========================================
+ Coverage   80.55%   80.58%   +0.02%     
==========================================
  Files         925      919       -6     
  Lines      259303   258851     -452     
==========================================
- Hits       208886   208585     -301     
+ Misses      50417    50266     -151     
Flag Coverage Δ
fuzzcorpus 56.15% <61.42%> (+0.01%) ⬆️
livemode 19.42% <35.60%> (+0.02%) ⬆️
pcap 44.26% <54.30%> (+0.04%) ⬆️
suricata-verify 63.42% <92.87%> (+0.08%) ⬆️
unittests 58.38% <47.31%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 24421

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants