lua: provide base64 lib to lua - v2 #12498
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
WARNING:
Pipeline 24405 |
|
Information: QA ran without warnings. Pipeline 24422 |
catenacyber
reviewed
Jan 29, 2025
| uint8_t *decoded = SCCalloc(decoded_len, sizeof(uint8_t)); | ||
|
|
||
| for (uint8_t mode = Base64ModeRFC2045; mode <= Base64ModeStrict; mode++) { | ||
| (void)Base64Decode(src, len, mode, decoded); | ||
| for (uint8_t mode = SCBase64ModeRFC2045; mode <= SCBase64ModeStrict; mode++) { |
There was a problem hiding this comment.
Ouch, you changed the order in the enum, so this loop quits too early
catenacyber
reviewed
Jan 29, 2025
| @@ -40,7 +40,7 @@ | |||
| static int DetectTransformFromSCBase64DecodeSetup(DetectEngineCtx *, Signature *, const char *); | |||
| static void DetectTransformFromSCBase64DecodeFree(DetectEngineCtx *, void *); | |||
| #ifdef UNITTESTS | |||
| #define DETECT_TRANSFORM_FROM_BASE64_MODE_DEFAULT (uint8_t)SCBase64ModeRFC4648 | |||
| #define DETECT_TRANSFORM_FROM_BASE64_MODE_DEFAULT (uint8_t) SCBase64ModeRFC4648 | |||
There was a problem hiding this comment.
not in right commit :-p
catenacyber
reviewed
Jan 29, 2025
| FAIL_IF_NOT(buffer.inspect_len == 15); | ||
| // PrintRawDataFp(stdout, buffer.inspect, buffer.inspect_len); | ||
| InspectionBufferFree(&buffer); | ||
| PASS; | ||
| } | ||
| static void DetectTransformFromBase64DecodeRegisterTests(void) | ||
| static void DetectTransformFromSCBase64DecodeRegisterTests(void) |
There was a problem hiding this comment.
Your grep|sed is gone too far :-p
catenacyber
reviewed
Jan 29, 2025
| size_t input_len; | ||
| const char *input = luaL_checklstring(L, 1, &input_len); | ||
| size_t out_len = SCBase64EncodeBufferSize(input_len); | ||
| char output[out_len + 1]; |
There was a problem hiding this comment.
I do not like stack alloc... How big can it get ?
catenacyber
reviewed
Jan 29, 2025
| let mut num_decoded: u32 = 0; | ||
| let config = base64::engine::GeneralPurposeConfig::new() | ||
| .with_decode_padding_mode(base64::engine::DecodePaddingMode::Indifferent); | ||
| let decoder = base64::engine::GeneralPurpose::new(&base64::alphabet::STANDARD, config); |
There was a problem hiding this comment.
How lenient is this ? Like tolerating spaces inside the base64 ?
catenacyber
requested changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a Lua library exposing basic base64 functions to Lua. For details on the
function checkout the base64.rst page added in the userguide.
Commits:
SV_BRANCH=OISF/suricata-verify#2260