Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output/TLS: Allow logging of client/server handshake parameters - V2 #12501

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+333 −73
Open

Output/TLS: Allow logging of client/server handshake parameters - V2 #12501

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions doc/userguide/output/eve/eve-json-format.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1040,6 +1040,11 @@ If extended logging is enabled the following fields are also included:
* "ja4": The JA4 client fingerprint for TLS
* "client_alpns": array of strings with ALPN values
* "server_alpns": array of strings with ALPN values
* "client_handshake": structure containing "version", "ciphers", "exts", "sig_algs", for client
hello supported cipher suites, extensions, and signature algorithms,
respectively, in the order that they're mentioned (ie. unsorted)
* "server_handshake": structure containing "version", "chosen cipher", "exts", for server hello
in the order that they're mentioned (ie. unsorted)

JA3 and JA4 must be enabled in the Suricata config file (set 'app-layer.protocols.tls.ja3-fingerprints'/'app-layer.protocols.tls.ja4-fingerprints' to 'yes').

Expand Down
51 changes: 51 additions & 0 deletions etc/schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6722,13 +6722,61 @@
"type": "string"
}
},
"client_handshake": {
"type": "object",
"properties": {
"version": {
"type": "string"
},
"ciphers": {
"description": "TLS client cipher(s)",
"type": "array",
"items": {
"type": "integer"
}
},
"exts": {
"description": "TLS client extension(s)",
"type": "array",
"items": {
"type": "integer"
}
},
"sig_algs": {
"description": "TLS client signature algorithm(s)",
"type": "array",
"items": {
"type": "integer"
}
}
}
},
"server_alpns": {
"description": "TLS server ALPN field(s)",
"type": "array",
"items": {
"type": "string"
}
},
"server_handshake": {
"type": "object",
"properties": {
"version": {
"type": "string"
},
"cipher": {
"description": "TLS server's chosen cipher",
"type": "integer"
},
"exts": {
"description": "TLS server extension(s)",
"type": "array",
"items": {
"type": "integer"
}
}
}
},
"fingerprint": {
"type": "string"
},
Expand Down Expand Up @@ -6792,6 +6840,9 @@
},
"ja4": {
"type": "string"
},
"ja4s": {
"type": "string"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there not some license question around ja4s ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this needs at least to be in its own commit

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding the label [decision-required] about this point

}
},
"additionalProperties": false
Expand Down
Loading
Loading