Libhtp rs v27.3 #12538
Libhtp rs v27.3 #12538
Conversation
In preparation of libhtp rust
In preparation of libhtp rust
|
ERROR: ERROR: QA failed on build_asan. Pipeline 24648 |
catenacyber
force-pushed
the
libhtp-rs-v27.3
branch
from
c668c6c to
dd2e64a
Compare
|
ERROR: ERROR: QA failed on build_asan. Pipeline 24654 |
catenacyber
force-pushed
the
libhtp-rs-v27.3
branch
from
dd2e64a to
6cd5dd1
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12538 +/- ##
==========================================
+ Coverage 80.68% 80.71% +0.02%
==========================================
Files 925 925
Lines 258914 258929 +15
==========================================
+ Hits 208914 208987 +73
+ Misses 50000 49942 -58
Flags with carried forward coverage won't be shown. Click here to find out more. |
| { "RESPONSE_FIELD_MISSING_COLON", HTTP_DECODER_EVENT_RESPONSE_FIELD_MISSING_COLON }, | ||
| { "INVALID_REQUEST_CHUNK_LEN", HTTP_DECODER_EVENT_INVALID_REQUEST_CHUNK_LEN }, | ||
| { "INVALID_RESPONSE_CHUNK_LEN", HTTP_DECODER_EVENT_INVALID_RESPONSE_CHUNK_LEN }, | ||
| { "UNKNOWN_ERROR", HTP_LOG_CODE_UNKNOWN }, |
There was a problem hiding this comment.
Is the change from the HTTP prefix to HTP a change that was made in the libhtp Rust conversion?
There was a problem hiding this comment.
Indeed, it is a change that vill be made cf #12508 commit message :
libhtp logging API updated to provide HTP_LOG_CODE constants along with
the message. This eliminates the need to perform string matching on
message text to map log messages to HTTP_DECODER_EVENT values, and the
HTP_LOG_CODE values can be used directly. In support of this,
HTP_DECODER_EVENT values are mapped to their corresponding HTP_LOG_CODE
values:
HTTP_DECODER_EVENT_UNKNOWN_ERROR => HTP_LOG_CODE_UNKNOWN
In preparation of libhtp rust
In preparation of libhtp rust
catenacyber
force-pushed
the
libhtp-rs-v27.3
branch
from
6cd5dd1 to
0c48705
Compare
|
Information: QA ran without warnings. Pipeline 24661 |
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/2696
Describe changes:
This allow to go one small step further
#12509 next round now focusing on src/app-layer-htp.c