tool: rewrite suricatasc and suricatactl in rust - v13 #12561
+2,126
−1,094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a re-implementation of suricatasc program in Rust that attempts to be a 100% drop-in replacement.
As we have 2 Windows builds, do one using the release-style distribution file.
These should probably be removed even without the rewrite, and suricatasc has been installed as a proper program for many releases.
After a build, check if Cargo.lock.in and Cargo.lock differ, if so, Cargo.lock.in needs an update as part of a depedency update.
Without this script `make distcheck` fails on a system with documentation tooling installed, as its required to build the EVE appendix.
The version we have been using will be deprecated soon. https://github.blog/changelog/2024-12-05-notice-of-upcoming-releases-and-breaking-changes-for-github-actions/#actions-cache-v1-v2-and-actions-toolkit-cache-package-closing-down
jasonish
requested review from
inashivb,
jufajardini and
a team
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12561 +/- ##
==========================================
- Coverage 80.71% 80.71% -0.01%
==========================================
Files 928 929 +1
Lines 259007 259010 +3
==========================================
- Hits 209063 209054 -9
- Misses 49944 49956 +12
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
RPM builds expected to fail. I could disable them for now, but fixing the RPMs required the breaking changes (for them) to be merged into Suricata master first. |
|
Information: QA ran without warnings. Pipeline 24691 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous PR: #12554
Changes:
default features, and we depend on. Should fix CI.
Replaces suricatasc and suricatactl with Rust variants removing python from our
distributed code (except suricata-update).
These now pass CI as some CI tests now use suricatasc where they didn't in the
previous version.
These should also be pure drop-in replacements.
Usually rewrites are a bad idea, but these are small, and in our core language
set, and may inspire us to write new more interesting tooling in the future,
like perhaps a plugin manager?
Ticket: https://redmine.openinfosecfoundation.org/issues/6287