lua: remove default search path for output modules - v1 #12563
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonish
requested review from
jufajardini,
victorjulien and
a team
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12563 +/- ##
=======================================
Coverage 80.70% 80.70%
=======================================
Files 928 928
Lines 259013 259034 +21
=======================================
+ Hits 209033 209055 +22
+ Misses 49980 49979 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 24690 |
jasonish
commented
Feb 12, 2025
src/output-lua.c
Outdated
Comment on lines
655
to
660
| BUG_ON(parent_ctx == NULL); | ||
| LogLuaMasterCtx *mc = parent_ctx->data; | ||
| BUG_ON(mc == NULL); | ||
|
|
||
| const char *dir = ""; | ||
| if (parent_ctx && parent_ctx->data) { | ||
| LogLuaMasterCtx *mc = parent_ctx->data; | ||
| dir = mc->path; | ||
| } | ||
| dir = mc->script_dir; |
There was a problem hiding this comment.
This is all to show that I don't think parent_ctx and parent_ctx->data can be NULL anymore, or its not clear how we could here with them being NULL.
jasonish
force-pushed
the
lua-path/v1
branch
from
c6a8703 to
a8311af
Compare
It had a rather generic name of "path", which in Lua usually means a search path, which we'll be adding.
By default, use an empty search path. This gives us a predictable default. If a user needs access to external modules, the search path must be set in the configuration file. Ticket: OISF#7169
- Sandboxed Lua for rules - Search path changes for Lua output scripts
jasonish
force-pushed
the
lua-path/v1
branch
from
a8311af to
1f8fab7
Compare
|
Information: QA ran without warnings. Pipeline 24701 |
|
Replaced by #12576 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the search path for Lua modules. It now must be set in the
configuration file. This provides a consistent starting point for all installs
of Suricata.
As we no longer use the system provided Lua, we can't provide a sane default
for every installation environment.
Ticket: https://redmine.openinfosecfoundation.org/issues/7169