Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

batch implementation of feedback for TX1.3 #426

Merged
merged 77 commits into from
Jun 13, 2023
Merged

batch implementation of feedback for TX1.3 #426

merged 77 commits into from
Jun 13, 2023

Conversation

costezki
Copy link
Collaborator

@costezki costezki commented Jun 13, 2023

batch implementation of feedback for TX1.3

  • The following issues have been address:

From milestone 2023-05:

From milestone 2023-04:

valexande and others added 30 commits May 2, 2023 15:25
This reverts commit d9e0301
…f non-F13-specific mappings, which were done in previous commits related to fixing issues #358, to keep technical mapping of different forms in sync. This has no effect on the generated output.
…g the legalBasis to the previous notice, not the "current" one.
…e fix for #390 was wrong (due to problem with rmlmapper.jar).
…. I.e. Attaching the contract nature to the ContractTerm on the Procedure, not on the Lot, as it ws done in the first attempt.
…likely by Csongor, but the tools were not runned to regenerated the output. I runned the tools for regenerating the output, and all org:Organisation were removed.
…rganisationGroup #352"

The epo:hasBuyerLegalTypeDescription is now attached to BuyerOrganizationGroup when OrganizationGroup and Organization exist on parallel in the notice.
csnyulas and others added 23 commits June 9, 2023 22:55
… being activated (i.e. `epo:Contract` is not being instantiated) after the previous fix.
…NonAwardedContractTitle` property either.
…k agreements, provide justification for any duration exceeding 4/8 years #417""

This reverts commit eb5d565.
…enerating output for F13 (no changes occurred)
@costezki costezki added this to the 2023-05 milestone Jun 13, 2023
@costezki costezki requested review from csnyulas and valexande June 13, 2023 16:38
@swarmia
Copy link

swarmia bot commented Jun 13, 2023

✅  Linked to Epic TED-1302 · TX1.3 & 1.4 Re-Delivery work

Copy link
Collaborator

@valexande valexande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve :)

@costezki costezki merged commit 6421d82 into main Jun 13, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants