-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
batch implementation of feedback for TX1.3 #426
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d9e0301
…f non-F13-specific mappings, which were done in previous commits related to fixing issues #358, to keep technical mapping of different forms in sync. This has no effect on the generated output.
…g the legalBasis to the previous notice, not the "current" one.
…e fix for #390 was wrong (due to problem with rmlmapper.jar).
…. I.e. Attaching the contract nature to the ContractTerm on the Procedure, not on the Lot, as it ws done in the first attempt.
…mapping into feature/TED-1302
…likely by Csongor, but the tools were not runned to regenerated the output. I runned the tools for regenerating the output, and all org:Organisation were removed.
…rganisationGroup #352" The epo:hasBuyerLegalTypeDescription is now attached to BuyerOrganizationGroup when OrganizationGroup and Organization exist on parallel in the notice.
✅ Linked to Epic TED-1302 · TX1.3 & 1.4 Re-Delivery work |
valexande
approved these changes
Jun 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve :)
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
batch implementation of feedback for TX1.3
The following issues have been address:
From milestone 2023-05:
epo:ContractModification
instances #419epo:containsModificationsOf
mappings in the CM #416epo:refersToLot
relation originating from the Notice instance #415epo:announcesTender
relation originating from the Notice instance #414epo:announcesContract
toepo-not:refersToContractToBeModified
#413epo:announcesRole
(norepo:refersToRole
) in ContractModificationNotice #411epo:containsModificationsOn
toepo:containsModificationsOf
#410From milestone 2023-04:
rdf:type
of the Winner organization defined in section V.3.3 of form F13:org:Organisation
should beorg:Organization
#347