Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation marker upload animation #250

Merged

Conversation

yulieth9109
Copy link
Contributor

No description provided.

@yulieth9109 yulieth9109 force-pushed the upload_animation branch 2 times, most recently from 95af23d to e345138 Compare March 14, 2024 14:19
Copy link
Member

@Robbendebiene Robbendebiene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added one more TODO in the code.

Also we should probably dispose the generated image in the widgets dispose method or whenever we create a new one in didUpdateWidget.

lib/api/app_worker/element_handler.dart Outdated Show resolved Hide resolved
lib/widgets/osm_element_layer/upload_animation.dart Outdated Show resolved Hide resolved
@yulieth9109 yulieth9109 force-pushed the upload_animation branch 6 times, most recently from dfacdc8 to e4d942f Compare April 22, 2024 20:14
lib/widgets/osm_element_layer/osm_element_layer.dart Outdated Show resolved Hide resolved
lib/widgets/osm_element_layer/upload_animation.dart Outdated Show resolved Hide resolved
lib/widgets/osm_element_layer/upload_animation.dart Outdated Show resolved Hide resolved
lib/widgets/osm_element_layer/upload_animation.dart Outdated Show resolved Hide resolved
lib/widgets/osm_element_layer/upload_animation.dart Outdated Show resolved Hide resolved
lib/widgets/osm_element_layer/upload_animation.dart Outdated Show resolved Hide resolved
lib/view_models/home_view_model.dart Outdated Show resolved Hide resolved
lib/widgets/osm_element_layer/upload_animation.dart Outdated Show resolved Hide resolved
lib/widgets/osm_element_layer/upload_animation.dart Outdated Show resolved Hide resolved
lib/widgets/osm_element_layer/upload_animation.dart Outdated Show resolved Hide resolved
lib/widgets/osm_element_layer/upload_animation.dart Outdated Show resolved Hide resolved
lib/widgets/osm_element_layer/upload_animation.dart Outdated Show resolved Hide resolved
@Robbendebiene Robbendebiene changed the base branch from master to upload_animation June 6, 2024 08:44
@Robbendebiene Robbendebiene merged commit 4bcf409 into OPENER-next:upload_animation Jun 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants