Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split footway map feature into more detailed features #300

Merged
merged 5 commits into from
Dec 9, 2024
Merged

Split footway map feature into more detailed features #300

merged 5 commits into from
Dec 9, 2024

Conversation

Robbendebiene
Copy link
Member

Implements #298

  • Also adds a combined foot- & cycle path crossing map feature
  • Introduces map feature priorities and removes the map feature score. Both systems help to decide which map feature should take precedence when multiple match the same element.
  • Minor fixes

@Robbendebiene Robbendebiene requested a review from 7h30n3 December 3, 2024 08:03
7h30n3
7h30n3 requested changes Dec 3, 2024
View reviewed changes
lib/models/map_features/map_features.dart Show resolved Hide resolved
lib/l10n/app_en.arb Show resolved Hide resolved
@Robbendebiene Robbendebiene linked an issue Dec 3, 2024 that may be closed by this pull request
Cycle & Foot Paths are marked as Footpaths #298
Closed
@Robbendebiene
Remove surface conditions for prefixed surface questions
0eae4ea 
Reasoning: There are too many elements that represent a pure cycleway or footway but are tagged with cycleway:surface or footway:surface instead of just surface. (e.g. https://www.openstreetmap.org/way/386759511) Therefore we cannot safely assume if one of the prefixed tags (e.g. cycleway:surface) is set the other (footway:surface) is missing.
@Robbendebiene Robbendebiene merged commit 638b731 into master Dec 9, 2024
2 of 3 checks passed
@Robbendebiene Robbendebiene deleted the split-footway-feature branch December 9, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7h30n3 7h30n3 7h30n3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cycle & Foot Paths are marked as Footpaths
2 participants
@Robbendebiene @7h30n3