Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 2xxx DELFI attributes #83

Merged
merged 3 commits into from
Jun 17, 2022
Merged

Add 2xxx DELFI attributes #83

merged 3 commits into from
Jun 17, 2022

Conversation

7h30n3
Copy link
Member

@7h30n3 7h30n3 commented Jun 3, 2022

No description provided.

Copy link
Member

@Robbendebiene Robbendebiene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things that are missing:

What about:

Since we also plan to ask for left/right side walks (which heavily depends on visualizing the direction of the way/path) we could also ask for stuff like:

  • 2133 - conveying
  • 2132 - incline
    Maybe this could be understandable for the user if we phrase it like this: "Is the moving direction of the escalator in-line with the arrow direction on the map?"

We also currently do not have any tag that holds the smallest width on a platform (Engstelle). https://wiki.openstreetmap.org/wiki/DE:Key:maxwidth:physical is probably not the right tag for this. Maybe we could build uppon https://wiki.openstreetmap.org/wiki/Key:narrow and instead of yes supply a specific length value.

@7h30n3 7h30n3 changed the title First draft for adding 2xxx DELFI attributes Add 2xxx DELFI attributes Jun 17, 2022
@7h30n3 7h30n3 marked this pull request as ready for review June 17, 2022 07:33
@@ -150,5 +161,29 @@
"emergency": "phone"
},
"osm_element": "Node"
},
{
"name": "Tür",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be "Durchgang"? maybe we name it "Durchgang/Tür" because most of the time it will be a door.

"osm_element": "Node"
},
{
"name": "Weg",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe name this "Fußweg"

@7h30n3 7h30n3 merged commit 6403adf into master Jun 17, 2022
@7h30n3 7h30n3 deleted the extend_question_catalog branch June 17, 2022 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants