Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo Tranverse->Transverse and many other fixes #4336

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

mwtoews
Copy link
Member

@mwtoews mwtoews commented Dec 4, 2024

This fixes a number of typos found and corrected with a modern version of codespell. Here are some notes and observations:

  • The most visible correction is Tranverse->Transverse
  • Some of the corrections were not necessarily wrong before, but are dated forms, e.g., advertize or synthetize
  • Others are French, e.g. instanciation
  • There is scripts/fix_typos.sh in the repo (based on an older fork of codespell), but either it hasn't been run for a while or it doesn't have the dictionaries to catch the ones in this PR? I could consider a subsequent PR to this one to run modern codespell in CI, which runs in a few seconds.
  • There are a number of typos from EPSG's data that are not fixed here, but I might report them to IOGP.

Copy link
Member

@kbevers kbevers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard to argue against improving spelling. Good work.

I must be the culprit for a lot of these. Both because English isn't my first language, but more likely because I have to turn off the spellchecker when building the docs locally before releases (I haven't found a way to make the sphinx spellchecker work on my ARM-based Mac).

CODE_OF_CONDUCT.md Outdated Show resolved Hide resolved
docs/source/community/code_of_conduct.rst Outdated Show resolved Hide resolved
@mwtoews
Copy link
Member Author

mwtoews commented Dec 4, 2024

I've certainly made my fair share of typos, so no need to take any blame. I'll look into embedding spellchecking into the CI process to minimise these going forward, which could also replace "sphinxcontrib.spelling" too.

@kbevers
Copy link
Member

kbevers commented Dec 5, 2024

I'll look into embedding spellchecking into the CI process to minimise these going forward, which could also replace "sphinxcontrib.spelling" too.

We already have that:
https://github.com/OSGeo/PROJ/blob/master/.github/workflows/doc_checks.yml

It has a long list of ignored words in this file. One of the words is "Tranverse" :)

@mwtoews
Copy link
Member Author

mwtoews commented Dec 5, 2024

"Tranverse" was added to the ignore list recently; see 693620f

@rouault rouault merged commit 6d7c8c2 into OSGeo:master Dec 5, 2024
25 checks passed
@mwtoews mwtoews deleted the tranverse-typos branch December 5, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants