Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ETRFxxx to ETRFyyy, and WGS 84 (xxx) to WGS 84 (yyy) #4364

Merged
merged 5 commits into from
Jan 5, 2025

Conversation

rouault
Copy link
Member

@rouault rouault commented Jan 2, 2025

(on top of #4363 for convenience)

  • createOperations(): more relevant ETRFxxxx to ETRFyyyy results
  • Database: add concatenated operations for all WGS 84 (xxx) to WGS 84 (yyy) realizations

@rouault rouault added this to the 9.6.0 milestone Jan 2, 2025
@jjimenezshaw
Copy link
Contributor

jjimenezshaw commented Jan 2, 2025

@rouault
Copy link
Member Author

rouault commented Jan 2, 2025

I don't know if you want to consider differently ETRF2000-PL

As far as I can see this pull request doesn't affect anything related to it. This pull request only affects transformations between "regular" / non-national-specific ETRFxxxx that imply going through ITRF.

ETRF2000-PL is only connected to generic ETRS89 and WGS 84 through a null transformation.
So you get things like (with or without this PR):

$ PROJ_DATA=data bin/projinfo -s "ETRF2000-PL" -t "ETRF2014" -o PROJ
Candidate operations found: 1
-------------------------------------
Operation No. 1:

unknown id, ETRF2000-PL to ETRS89 (1) + ETRS89 to ETRF2014, 0.1 m, Poland - onshore and offshore.

PROJ string:
+proj=noop

which is probably suboptimal if one could reasonably consider ETRF2000-PL to be equivalent to ETRF2000 (but can we... ?)

@jjimenezshaw
Copy link
Contributor

I said that just because there is a check "starts_with("ETRF")"

@rouault
Copy link
Member Author

rouault commented Jan 2, 2025

I said that just because there is a check "starts_with("ETRF")"

yes, thanks for raising this. The code should be safe even with ETRF2000-PL (if one day there would be a connection between ETRF2000-PL and ITRFxxxx, then the added logic would probably make sense). I've added a test to check that ETRF2000-PL to ETRF2014 doesn't misbehave badly.

@rouault rouault merged commit 177f6f3 into OSGeo:master Jan 5, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants