Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDF: remove write support for GEO_ENCODING=OGC_BP #11048

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rouault
Copy link
Member

@rouault rouault commented Oct 19, 2024

for 3.11

Several reasons:

  • support for SRS has always been partial (contrary to the default ISO32000 encoding)
  • and the actual trigger for this pull request: lately the company behind the OGC Best Practice encoding has behaved in a unfriendly way with respect to our community. No need to promote their techs further.

CC @nyalldawson Will that be an issue for QGIS?

@rouault rouault added this to the 3.11.0 milestone Oct 19, 2024
for 3.11

Several reasons:
- support for SRS has always been partial
- and the actual trigger for this pull request: lately the company
  behind the OGC Best Practice encoding has behaved in a unfriendly way
  with respect to our community. No need to promote their techs further.
@rouault rouault force-pushed the pdf_remove_write_ogc_bp branch from 3d0c114 to 31f2f4e Compare October 19, 2024 03:21
@nyalldawson
Copy link
Collaborator

Will that be an issue for QGIS?

Well, we'll need to remove that export options at least. I'm unsure how widely used it is.

@andreasneumann do you know if this option is required for compliance? Perhaps you could check with the Swiss user group?

@rouault
Copy link
Member Author

rouault commented Oct 20, 2024

I'm unsure how widely used it is.

I had some memories that PDF created with the OGC_BP couldn't be properly read with the T....Go toolbar due to it requiring them to be signed (it could open them, but wouldn't take into account the georeferenced info). But I could be wrong.

@rouault rouault added the funded through GSP Work funded through the GDAL Sponsorship Program label Oct 24, 2024
@rouault rouault marked this pull request as draft November 13, 2024 22:56
Copy link

The GDAL project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 28 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular link
    to any issues which this pull request fixes

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in 2 weeks.

@github-actions github-actions bot added the stale label Dec 12, 2024
Copy link

While we hate to see this happen, this PR has been automatically closed because it has not had any activity in the last 6 weeks. If this pull request should be reconsidered, please follow the guidelines in the previous comment and reopen this pull request. Or, if you have any further questions, just ask! We love to help, and if there's anything the GDAL project can do to help push this PR forward please let us know how we can assist.

@github-actions github-actions bot closed this Dec 27, 2024
@rouault rouault reopened this Dec 27, 2024
@rouault
Copy link
Member Author

rouault commented Dec 27, 2024

gentle ping @andreasneumann

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 69.905% (-0.04%) from 69.945%
when pulling 31f2f4e on rouault:pdf_remove_write_ogc_bp
into c904cbc on OSGeo:master.

@stale stale bot removed the stale label Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
funded through GSP Work funded through the GDAL Sponsorship Program
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants