Explicitly set CMAKE_CXX_SCAN_FOR_MODULES=0 #11615
Merged
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks reasonable. By chance do we know if this has been fixed in the latest CMake versions? If so, we could possibly add a test on the CMake version (although that might bring little benefits) |
I'm using a pretty current version. I think there's something about our dependency chain causing this check to be triggered. That chain is so large there's probably no way to prevent it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something about my configuration was causing the following complaint
Some searching showed https://discourse.cmake.org/t/cmake-3-28-cmake-cxx-compiler-clang-scan-deps-notfound-not-found/9244/3
My configuration didn't have
clang-toolsinstalled, so I didn't haveclang-scan-depsavailable. I shouldn't have needed it, but I don't understand why our CMake configuration thinks it does.This PR tells CMake that it doesn't need it. When we upgrade to C++20 modules 😄, we can switch it back on.