python: Early exit from functions or loops #4910
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flattens nested conditionals and moves error messages near the top
Flattens nested conditionals and moves error messages or returns near the top
This was referenced Jan 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extracts the refactorings made by the Pyrefact tool concerning early exiting loops or functions, and changes related to changing the order of the conditions. Ruff has some rules, that are ignored, that can detect some of these. Some similar changes were already done a couple of months ago, but the pyrefact tool seems more powerful for these as it manipulates the AST (thus why some comments are lost and I manually replace them). I expect the ruff issue count (including ignored) to be smaller after these changes.