-
-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wxGUI: Updated exception handling to fix AttributeNotFound error #4961
Conversation
Indeed, PyDeadObjectError doesn't exist in the Phoenix version of wxPython (version 4 and after), like explained in the migration docs It is fine since it was decided in #4890 that we can keep support for only version 4 and up. |
@petrasovaa mentioned an error while downloading sample project to GRASS database and sent this trace
|
There's another PyDeadObject error in grass/gui/wxpython/mapwin/graphics.py Line 391 in 8e575c2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is fine by itself. While it won't fix the root issue of the stack trace shared here, as it doesn't address the parent.sizer not found (maybe Sizer?), it does fix one of the errors occurring during exception handling.
So two things to do somewhere else (if wanted): fix the sizer not found causing the issue, and search for other wx.PyDeadObjectError in the repo. I found 2 total, this fixes one.
@arohanajit could you look into that as well? |
An error was highlighted mentioning error
module 'wx' has no attribute 'PyDeadObjectError'
in the relevant code. This PR is to update the code with other relevant exceptions to replace that