i.biomass: added test file for i.biomass module #4962
Conversation
github-actions
bot
added
Python
| ) | ||
| cls.del_temp_region() | ||
|
|
||
| def test_biomass_with_zero_inputs(self): |
There was a problem hiding this comment.
I don't think this is particularly useful test. Instead, do a regression test to make sure the values stay the same.
There was a problem hiding this comment.
Thank you for the suggestion! I have replaced the test with a regression test to ensure the values remain consistent.
| def test_biomass_regression(self): | ||
| """Regression test to ensure i.biomass output remains consistent.""" | ||
| self._create_reference_raster() | ||
| reference_raster = "biomass_reference" | ||
|
|
||
| self.assertModule( | ||
| "i.biomass", | ||
| fpar=self.input_rasters["fpar"], | ||
| lightuse_efficiency=self.input_rasters["lightuse_eff"], | ||
| latitude=self.input_rasters["latitude"], | ||
| dayofyear=self.input_rasters["dayofyear"], | ||
| transmissivity_singleway=self.input_rasters["transmissivity"], | ||
| water_availability=self.input_rasters["water"], | ||
| output=self.output_raster, | ||
| overwrite=True, | ||
| ) | ||
| self.assertRasterExists(self.output_raster) | ||
| self.assertRasterExists(reference_raster) | ||
|
|
||
| output_values = array.array(self.output_raster) | ||
| reference_values = array.array(reference_raster) | ||
|
|
||
| self.assertTrue( | ||
| np.allclose(output_values, reference_values, atol=2.0), | ||
| "Biomass raster values should match the reference values", | ||
| ) |
There was a problem hiding this comment.
That's not what I had in mind. You are computing the reference raster with each test run, but the idea is to compute the reference at the moment you are writing the test and then this reference is considered to be correct, the values are fixed in the test. So when somebody later changes the tool, resulting in different results, the test will fail and you will know that there is potentially a newly introduced bug. See for example r.viewshed test. It is often enough to compute univariate statistics with r.univar and then test those statistics, not cell-by-cell comparison.
This PR introduces a suite of tests for the
i.biomassGRASS GIS module, covering a range of scenarios, including functionality validation, property testing, edge cases, and performance evaluation.Key updates in this PR include:
Test Case Additions:
Basic Functionality:
Advanced Properties:
Edge Cases:
Performance: