Added Graphql Poc for projectDetails page #592
+823
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i will fix these workflow later |
arkid15r
requested changes
Jan 24, 2025
There was a problem hiding this comment.
Thanks for adding this!
I didn't review the code as pre-commit failed but based on the file structure I can already recommend the following changes:
- use common app for the base schema definition
- use existing apps structure (github/owasp) to define related graphql queries/types (e.g. owasp/graphql/...`)
- we won't be doing any mutations
- the main graphql schema entry point could be something like
settings.graphql
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #524
Add the PR description here.
Screencast.from.24-01-25.04.51.49.AM.IST.webm