Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Graphql Poc for projectDetails page #592

Merged
merged 12 commits into from
Jan 26, 2025

Conversation

abhayymishraa
Copy link
Collaborator

@abhayymishraa abhayymishraa commented Jan 23, 2025

Resolves #524

Add the PR description here.

  • Implemented graphene for backend, exposing graphql
  • Apolloclient for the frontend
  • grapqhl for frontend
  • Initally setup of the graphql structure
Screencast.from.24-01-25.04.51.49.AM.IST.webm

@abhayymishraa
Copy link
Collaborator Author

abhayymishraa commented Jan 23, 2025

i will fix these workflow later

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

I didn't review the code as pre-commit failed but based on the file structure I can already recommend the following changes:

  • use common app for the base schema definition
  • use existing apps structure (github/owasp) to define related graphql queries/types (e.g. owasp/graphql/...`)
  • we won't be doing any mutations
  • the main graphql schema entry point could be something like settings.graphql

@abhayymishraa
Copy link
Collaborator Author

abhayymishraa commented Jan 25, 2025

Looks great and organized!!!! @arkid15r

@abhayymishraa
Copy link
Collaborator Author

@arkid15r We still have the types directory inside the graphql folder, even though we've migrated the type to the node directory. Should we delete it?

@arkid15r
Copy link
Collaborator

@arkid15r We still have the types directory inside the graphql folder, even though we've migrated the type to the node directory. Should we delete it?

Yes, it's nodes now

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try it!

@arkid15r arkid15r added this pull request to the merge queue Jan 26, 2025
Merged via the queue into OWASP:main with commit 52df734 Jan 26, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement GraphQL PoC
2 participants