-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Graphql Poc for projectDetails page #592
Conversation
i will fix these workflow later |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this!
I didn't review the code as pre-commit failed but based on the file structure I can already recommend the following changes:
- use common app for the base schema definition
- use existing apps structure (github/owasp) to define related graphql queries/types (e.g. owasp/graphql/...`)
- we won't be doing any mutations
- the main graphql schema entry point could be something like
settings.graphql
Looks great and organized!!!! @arkid15r |
@arkid15r We still have the |
Yes, it's |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's try it!
Resolves #524
Add the PR description here.
Screencast.from.24-01-25.04.51.49.AM.IST.webm