Fixes some minor code issues #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1 +1,2 @@ | |||
| *.kdev4 | |||
| build | |||
There was a problem hiding this comment.
I usually use out-of-source builds (i.e. I make the build directory a sibling not a child of the project directory), but why not.
|
Oops, I just showed this tool to a friend of mine and came across this open PR of mine. Sorry for not responding here, this completely went under my radar. Feel free to close and / or cherry-pick. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are a few minor fixes I added while looking over the source to see how things work.
Beautiful idea and implementation, 👍 for that!
Depends on #2 since I needed it to compile the project. Feel free to squash the commits.