-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: fix inclusion aggregation bits for Electra #3501
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## electra #3501 +/- ##
==========================================
Coverage ? 57.51%
==========================================
Files ? 218
Lines ? 33698
Branches ? 0
==========================================
Hits ? 19380
Misses ? 12277
Partials ? 2041 ☔ View full report in Codecov by Sentry. |
pinebit
approved these changes
Feb 6, 2025
DiogoSantoss
approved these changes
Feb 6, 2025
1a0cf61
to
ba03ac5
Compare
a12958b
to
a7a7660
Compare
|
KaloyanTanev
added a commit
that referenced
this pull request
Feb 10, 2025
* Fix tracker aggregation bits attestations for electra * Add tests and fix linter * Remove test file * Fix final inclusion check * Fix TestInclusion test block structure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
electra
PR targeting electra upgrade
merge when ready
Indicates bulldozer bot may merge when all checks pass
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we have had aggregation bits of a single committee per attestation in the block. An example can be seen here - each attestation object has one single committee index.
In Electra, however, one single attestation object contains aggregation bits from multiple committees. this can be seen here. The aggregation bits object is a concatenation of all the committees participated in this attestation object.
This creates some issues in our inclusion checker. What we have been doing so far is to go over each attestation object and "merge" the attestations with the same hash root. Note that previously the committee index was part of the signed data, hence we had different hash root for each attestation object with different committee. Now the committee index is out of the signed data, hence signatures of the same data from committee X and X+1 is with the same hash root. That said, what we need to do now is for each attestation object:
Or
operation) to the aggregation bits for this committee onlycategory: feature
ticket: none