Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added plugin fractalbridge #942

Merged
merged 2 commits into from
Sep 16, 2021
Merged

Added plugin fractalbridge #942

merged 2 commits into from
Sep 16, 2021

Conversation

Popeyef5
Copy link
Contributor

No description provided.

Copy link
Contributor

@jneilliii jneilliii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small extension issue commented below, and we strongly recommend having a software update hook so that when you release new versions all users that have it installed get update notices when you publish new releases on GitHub.

@jneilliii
Copy link
Contributor

I think you need to make a small tweak to your software update hook implementation. Replace the line here with the following.

def __plugin_load__():
    global __plugin_implementation__
    __plugin_implementation__ = FractalBridgePlugin()

    global __plugin_hooks__
    __plugin_hooks__ = {
        "octoprint.plugin.softwareupdate.check_config": __plugin_implementation__.get_update_information,
    }

@Popeyef5
Copy link
Contributor Author

Thanks! Done

Copy link
Contributor

@jneilliii jneilliii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Would love to see delta printer support.

@jneilliii jneilliii merged commit 08ecaa8 into OctoPrint:gh-pages Sep 16, 2021
@Popeyef5
Copy link
Contributor Author

Thanks! We're launching publicly soon. In principle, it's printer agnostic (i.e. if there's a model you don't see as an option, you can just create it yourself and it will work just fine). We will definitely add Delta printer models as a default option though. We're adding a ton of features, and discussing others here: https://discord.gg/gHjjAqkVsZ

@jneilliii
Copy link
Contributor

jneilliii commented Sep 16, 2021

You may want to give more details to your readme on github, and possibly explain more/ link to fractal site here.

Screenshot_20210916-085931_Discord

@Popeyef5
Copy link
Contributor Author

Yes, sorry. The initial intent was to make the plugin available for the people beta testing the platform (so that they didn't have to install via a github URL). I didn't know people paid so much attention to plugin releases. I'll be sure to tidy things up in the plugin repo and in the description of the plugin.

@cp2004
Copy link
Member

cp2004 commented Sep 16, 2021

Please send in a new PR ASAP to edit the plugin's page on the repository, with at the very least a link to where people can find out more about the service. Or an explanation that the service is not live yet. Something so we don't have to answer endless questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants