fix: Improve logs for sentry error #2185
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
chrstph-dvx
commented
Jan 13, 2025
Comment on lines
67
to
71
| Sentry.getCurrentScope().setFingerprint([ | ||
| '{{ default }}', | ||
| code.toString(), | ||
| message | ||
| ]) |
There was a problem hiding this comment.
Current issue have multiple unrelated events, this should help split the future events properly
Comment on lines
+21
to
+24
| const query = new URLSearchParams(window.location.search) | ||
| for (const [key, value] of query.entries()) { | ||
| scope.setTag(key, value) | ||
| } |
There was a problem hiding this comment.
Adding query string to tags will help filtering events and issues
fionnachan
reviewed
Jan 17, 2025
fionnachan
reviewed
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Steps to test