Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features Needed After Sepolia Upgrade #716

Merged
merged 10 commits into from
Dec 16, 2024
Merged

Features Needed After Sepolia Upgrade #716

merged 10 commits into from
Dec 16, 2024

Conversation

rauljordan
Copy link
Collaborator

@rauljordan rauljordan commented Dec 12, 2024

This PR fixes a few items discovered after the Sepolia upgrade for BoLD

  • Support custom withdrawal address as a flag, defaulting to the txOpts.From if not specified
  • Support auto-deposit and auto-increase-allowance flags that run on startup if potential staker does not have enough deposit and/or allowance to participate
  • Add an option to call newStake on startup, disabled by default. Helps delegated stakers perform their duties

The auto-deposit feature occurs each time we make a move involving the stake token. There are three instances of this:

  • Opening a new stake on an assertion
  • Creating a block-challenge root edge
  • Creating a subchallenge root edge

We check the stake token address has code to ensure it is a valid contract

@eljobe eljobe self-requested a review December 13, 2024 00:27
@rauljordan rauljordan marked this pull request as draft December 13, 2024 22:20
@rauljordan rauljordan marked this pull request as ready for review December 13, 2024 22:20
Copy link
Member

@eljobe eljobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rauljordan rauljordan merged commit d3f4d60 into main Dec 16, 2024
5 checks passed
@rauljordan rauljordan deleted the post-sepolia-fixes branch December 16, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants