Use Desired RPC Block Number in Chain Watcher #720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauljordan
commented
Jan 4, 2025
rauljordan
commented
Jan 7, 2025
| @@ -204,7 +204,7 @@ func NewAssertionChain( | |||
| confirmedChallengesByParentAssertionHash: threadsafe.NewLruSet(1000, threadsafe.LruSetWithMetric[protocol.AssertionHash]("confirmedChallengesByParentAssertionHash")), | |||
| averageTimeForBlockCreation: time.Second * 12, | |||
| transactor: transactor, | |||
| rpcHeadBlockNumber: rpc.FinalizedBlockNumber, | |||
| rpcHeadBlockNumber: rpc.LatestBlockNumber, | |||
There was a problem hiding this comment.
Expects the operator to provide the RPC head block number to another value if desired. In Nitro, this will default to Finalized. Using Latest here makes sure that our tests remain fast without needing to change test setups across the whole codebase with options
rauljordan
commented
Jan 7, 2025
| @@ -108,11 +108,11 @@ type protocolParams struct { | |||
| func defaultProtocolParams() protocolParams { | |||
There was a problem hiding this comment.
Reducing values here for faster CI times
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR discovered that the chain watcher, which scrapes for challenge events from the chain, was not respecting the desired RPC block number configured by the user. For instance, if the software were configured to rely on finalized data, the watcher would just look at latest data and lead to errors at runtime when scraping chain events. Although non-critical, these are still important error logs to avoid in normal operation.
This PR also fixes a bit of log formatting and removes a certain condition of an edge's children not yet being tracked from being an error log. This also occurs when relying on finalized data, but resolves on its own