Skip to content

Commit

Permalink
Merge branch 'bold-merge-script' into bold-merge-action
Browse files Browse the repository at this point in the history
  • Loading branch information
gzeoneth authored Nov 21, 2024
2 parents a647b13 + a1cfde6 commit 1b1f090
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 6 deletions.
4 changes: 3 additions & 1 deletion audit-ci.jsonc
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,8 @@
// Valid ECDSA signatures erroneously rejected in Elliptic
"GHSA-fc9h-whq2-v747",
// secp256k1-node allows private key extraction over ECDH
"GHSA-584q-6j8j-r5pm"
"GHSA-584q-6j8j-r5pm",
// Regular Expression Denial of Service (ReDoS) in cross-spawn
"GHSA-3xgq-45jj-v275"
]
}
4 changes: 0 additions & 4 deletions scripts/boldUpgradeCommon.ts
Original file line number Diff line number Diff line change
Expand Up @@ -95,10 +95,6 @@ export const validateConfig = async (
config: Config,
l1Rpc: providers.Provider
) => {
// check all the config.contracts exist
// if ((await l1Rpc.getCode(config.contracts.excessStakeReceiver)).length <= 2) {
// throw new Error('excessStakeReceiver address is not a contract')
// }
if ((await l1Rpc.getCode(config.contracts.rollup)).length <= 2) {
throw new Error('rollup address is not a contract')
}
Expand Down
2 changes: 1 addition & 1 deletion scripts/executeBoldUpgrade.ts
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ async function perform(
timelockSigner
)

// // what validators did we have in the old rollup?
// what validators did we have in the old rollup?
const boldActionPerformData = boldAction.interface.encodeFunctionData(
'perform',
[config.validators]
Expand Down

0 comments on commit 1b1f090

Please sign in to comment.