Merge pull request #2910 from OffchainLabs/block_metadate_dontfetch

TransactionStreamer: dont fetch block metadata when unnecessary
OffchainLabs · Jan 30, 2025 · 1d9c68d · 1d9c68d
2 parents d1162ae + 7dfb491
commit 1d9c68d
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/arbnode/transaction_streamer.go b/arbnode/transaction_streamer.go
@@ -1141,6 +1141,10 @@ func (s *TransactionStreamer) BlockMetadataAtCount(count arbutil.MessageIndex) (
 	}
 	pos := count - 1
 
+	if s.trackBlockMetadataFrom == 0 || pos < s.trackBlockMetadataFrom {
+		return nil, nil
+	}
+
 	key := dbKey(blockMetadataInputFeedPrefix, uint64(pos))
 	blockMetadata, err := s.db.Get(key)
 	if err != nil {

diff --git a/system_tests/timeboost_test.go b/system_tests/timeboost_test.go
@@ -498,6 +498,7 @@ func TestTimeboostBulkBlockMetadataFetcher(t *testing.T) {
 	defer cancel()
 
 	builder := NewNodeBuilder(ctx).DefaultConfig(t, true)
+	builder.nodeConfig.TransactionStreamer.TrackBlockMetadataFrom = 1
 	httpConfig := genericconf.HTTPConfigDefault
 	httpConfig.Addr = "127.0.0.1"
 	httpConfig.Apply(builder.l2StackConfig)
@@ -630,6 +631,7 @@ func TestTimeboostedFieldInReceiptsObject(t *testing.T) {
 	defer cancel()
 
 	builder := NewNodeBuilder(ctx).DefaultConfig(t, false)
+	builder.nodeConfig.TransactionStreamer.TrackBlockMetadataFrom = 1
 	builder.execConfig.BlockMetadataApiCacheSize = 0 // Caching is disabled
 	cleanup := builder.Build(t)
 	defer cleanup()
@@ -738,6 +740,7 @@ func TestTimeboostBulkBlockMetadataAPI(t *testing.T) {
 	defer cancel()
 
 	builder := NewNodeBuilder(ctx).DefaultConfig(t, false)
+	builder.nodeConfig.TransactionStreamer.TrackBlockMetadataFrom = 1
 	builder.execConfig.BlockMetadataApiCacheSize = 0 // Caching is disabled
 	cleanup := builder.Build(t)
 	defer cleanup()
@@ -1334,6 +1337,7 @@ func setupExpressLaneAuction(
 		nodeConfig := arbnode.ConfigDefaultL1NonSequencerTest()
 		nodeConfig.Feed.Input = *newBroadcastClientConfigTest(port)
 		nodeConfig.Feed.Input.Timeout = broadcastclient.DefaultConfig.Timeout
+		nodeConfig.TransactionStreamer.TrackBlockMetadataFrom = 1
 		extraNode, cleanupExtraNode = builderSeq.Build2ndNode(t, &SecondNodeParams{nodeConfig: nodeConfig, stackConfig: testhelpers.CreateStackConfigForTest(t.TempDir())})
 	}