Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further improvements to Merkleization #2328

Merged
merged 54 commits into from
Jul 3, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
54 commits
Select commit Hold shift + click to select a range
35ce996
Use the json format from the go code for ValidationInputs.
eljobe May 8, 2024
c17383e
Merge branch 'merkle-perf' into merkle-perf-a
eljobe May 8, 2024
ac6c0c1
Merge branch 'merkle-perf' into merkle-perf-a
eljobe May 8, 2024
0badabb
Merge branch 'merkle-perf' into merkle-perf-a
eljobe May 10, 2024
76ee1df
Merge branch 'merkle-perf' into merkle-perf-a
eljobe May 10, 2024
9453b40
Add more counters.
eljobe May 10, 2024
e8c750a
Remove flush_module macro.
eljobe May 10, 2024
6ba0a69
Speed up block validation by another 27%.
eljobe May 13, 2024
d247ebd
Enable always_merkleize everywhere.
eljobe May 13, 2024
7013276
Make always_merkleize the only strategy.
eljobe May 13, 2024
2c5e055
Merge branch 'merkle-perf' into merkle-perf-a
eljobe May 16, 2024
5bda318
Merge branch 'merkle-perf-a' into merkle-perf-b
eljobe May 16, 2024
ffe7d07
Merge branch 'merkle-perf' into merkle-perf-a
eljobe May 17, 2024
febd3d8
Merge branch 'merkle-perf-a' into merkle-perf-b
eljobe May 17, 2024
ccc1ee0
Regenerate the Cargo.lock
eljobe May 17, 2024
d4a5fd0
Merge branch 'merkle-perf' into merkle-perf-a
eljobe May 21, 2024
0f769e8
Merge branch 'merkle-perf-a' into merkle-perf-b
eljobe May 21, 2024
0a0b8e4
Merge branch 'merkle-perf' into merkle-perf-a
eljobe May 21, 2024
75ac5b6
Merge branch 'merkle-perf-a' into merkle-perf-b
eljobe May 21, 2024
d2398d8
Remove --always-merkleize
eljobe May 21, 2024
9539e9a
Make clone create completely independent layers structs.
eljobe May 22, 2024
bbf8919
Merge branch 'merkle-perf' into merkle-perf-a
eljobe May 22, 2024
ba38163
Merge branch 'merkle-perf' into merkle-perf-a
eljobe May 22, 2024
31024b3
Merge branch 'merkle-perf' into merkle-perf-a
eljobe May 24, 2024
bd45054
Merge branch 'merkle-perf' into merkle-perf-a
eljobe May 27, 2024
b075b20
Make clippy happy.
eljobe May 27, 2024
4ec9470
Merge branch 'merkle-perf' into merkle-perf-a
eljobe May 29, 2024
a2d8601
Merge branch 'merkle-perf' into merkle-perf-a
eljobe Jun 3, 2024
21ba69b
Merge branch 'merkle-perf' into merkle-perf-a
eljobe Jun 4, 2024
c9c7052
Merge branch 'merkle-perf' into merkle-perf-a
eljobe Jun 4, 2024
8d074df
Fix Clone for the Memory type.
eljobe Jun 5, 2024
50627f2
Merge branch 'merkle-perf' into merkle-perf-a
eljobe Jun 6, 2024
1974d33
Remove race condition in merkelize.
eljobe Jun 6, 2024
256c6aa
Merge branch 'merkle-perf' into merkle-perf-a
eljobe Jun 7, 2024
d71cf50
Merge branch 'merkle-perf' into merkle-perf-a
eljobe Jun 10, 2024
bac89a8
Merge branch 'merkle-perf' into merkle-perf-a
eljobe Jun 11, 2024
fc5dd2a
Update Cargo.lock
eljobe Jun 11, 2024
5946941
Merge branch 'merkle-perf' into merkle-perf-a
eljobe Jun 11, 2024
9816df1
Merge branch 'merkle-perf' into merkle-perf-a
eljobe Jun 11, 2024
81e7cd7
Merge branch 'merkle-perf' into merkle-perf-a
eljobe Jun 12, 2024
4ebae58
Merge branch 'merkle-perf' into merkle-perf-a
eljobe Jun 14, 2024
f677872
Merge branch 'merkle-perf' into merkle-perf-a
eljobe Jun 17, 2024
3cc2310
Merge branch 'merkle-perf' into merkle-perf-a
eljobe Jun 18, 2024
75ef6ae
Merge branch 'merkle-perf' into merkle-perf-a
eljobe Jun 19, 2024
5636424
Merge branch 'merkle-perf' into merkle-perf-a
eljobe Jun 19, 2024
ab219b2
Merge branch 'merkle-perf' into merkle-perf-a
eljobe Jun 19, 2024
1e08774
Merge branch 'merkle-perf' into merkle-perf-a
eljobe Jun 20, 2024
46144f3
Merge branch 'merkle-perf' into merkle-perf-a
eljobe Jun 24, 2024
7c7977f
Merge branch 'merkle-perf' into merkle-perf-a
eljobe Jun 27, 2024
49db0ff
Merge branch 'merkle-perf' into merkle-perf-a
eljobe Jun 28, 2024
68b9317
Merge branch 'merkle-perf' into merkle-perf-a
eljobe Jun 28, 2024
3408d25
Merge branch 'merkle-perf' into merkle-perf-a
eljobe Jul 2, 2024
c697675
Merge branch 'merkle-perf' into merkle-perf-a
eljobe Jul 2, 2024
fe8c159
Make clippy happy.
eljobe Jul 2, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -428,10 +428,10 @@ $(stylus_test_erc20_wasm): $(stylus_test_erc20_src)
@touch -c $@ # cargo might decide to not rebuild the binary

contracts/test/prover/proofs/float%.json: $(arbitrator_cases)/float%.wasm $(prover_bin) $(output_latest)/soft-float.wasm
$(prover_bin) $< -l $(output_latest)/soft-float.wasm -o $@ -b --allow-hostapi --require-success --always-merkleize
$(prover_bin) $< -l $(output_latest)/soft-float.wasm -o $@ -b --allow-hostapi --require-success

contracts/test/prover/proofs/no-stack-pollution.json: $(arbitrator_cases)/no-stack-pollution.wasm $(prover_bin)
$(prover_bin) $< -o $@ --allow-hostapi --require-success --always-merkleize
$(prover_bin) $< -o $@ --allow-hostapi --require-success

target/testdata/preimages.bin:
mkdir -p `dirname $@`
Expand All @@ -455,19 +455,19 @@ contracts/test/prover/proofs/global-state.json:
echo "[]" > $@

contracts/test/prover/proofs/forward-test.json: $(arbitrator_cases)/forward-test.wasm $(arbitrator_tests_forward_deps) $(prover_bin)
$(prover_bin) $< -o $@ --allow-hostapi --always-merkleize $(patsubst %,-l %, $(arbitrator_tests_forward_deps))
$(prover_bin) $< -o $@ --allow-hostapi $(patsubst %,-l %, $(arbitrator_tests_forward_deps))

contracts/test/prover/proofs/link.json: $(arbitrator_cases)/link.wasm $(arbitrator_tests_link_deps) $(prover_bin)
$(prover_bin) $< -o $@ --allow-hostapi --always-merkleize --stylus-modules $(arbitrator_tests_link_deps) --require-success
$(prover_bin) $< -o $@ --allow-hostapi --stylus-modules $(arbitrator_tests_link_deps) --require-success

contracts/test/prover/proofs/dynamic.json: $(patsubst %,$(arbitrator_cases)/%.wasm, dynamic user) $(prover_bin)
$(prover_bin) $< -o $@ --allow-hostapi --always-merkleize --stylus-modules $(arbitrator_cases)/user.wasm --require-success
$(prover_bin) $< -o $@ --allow-hostapi --stylus-modules $(arbitrator_cases)/user.wasm --require-success

contracts/test/prover/proofs/bulk-memory.json: $(patsubst %,$(arbitrator_cases)/%.wasm, bulk-memory) $(prover_bin)
$(prover_bin) $< -o $@ --allow-hostapi --always-merkleize --stylus-modules $(arbitrator_cases)/user.wasm -b
$(prover_bin) $< -o $@ --allow-hostapi --stylus-modules $(arbitrator_cases)/user.wasm -b

contracts/test/prover/proofs/%.json: $(arbitrator_cases)/%.wasm $(prover_bin)
$(prover_bin) $< -o $@ --allow-hostapi --always-merkleize
$(prover_bin) $< -o $@ --allow-hostapi

# strategic rules to minimize dependency building

Expand Down
168 changes: 166 additions & 2 deletions arbitrator/Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion arbitrator/bench/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,15 @@ name = "benchbin"
path = "src/bin.rs"

[dependencies]
hex = "0.4.3"
hex = { version = "0.4.3", features = ["serde"] }
eyre = "0.6.5"
prover = { path = "../prover" }
arbutil = { path = "../arbutil" }
clap = { version = "4.4.8", features = ["derive"] }
gperftools = { version = "0.2.0", optional = true }
serde = { version = "1.0.130", features = ["derive", "rc"] }
serde_json = "1.0.67"
serde_with = { version = "3.8.1", features = ["base64"] }

[features]
counters = []
Expand Down
Loading
Loading