Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[config change] DAS filestore trie layout migrator and expiry, fixes: NIT-2538, NIT-2537 #2385

Merged
merged 21 commits into from
Jul 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
aab4e20
flat to trie layout migration
Tristan-Wilson Jun 5, 2024
e3a9f9e
Expiry implementation and tests
Tristan-Wilson Jun 8, 2024
45ab8a2
Logic for starting expiry, tests
Tristan-Wilson Jun 11, 2024
088c380
fix l1SyncService retention and expiry
Tristan-Wilson Jun 12, 2024
dac7512
Merge branch 'das-fix-l1SyncService' into das-filestore
Tristan-Wilson Jun 12, 2024
7596da6
Plumb retention period to legacy layout
Tristan-Wilson Jun 12, 2024
13f7958
Switch to ref counted expiry using hard links
Tristan-Wilson Jun 12, 2024
929c9c0
Unit test for handling of duplicates with expiry
Tristan-Wilson Jun 13, 2024
92aa569
Fix case of exactly same batch and expiry time
Tristan-Wilson Jun 13, 2024
510c979
Merge branch 'master' into das-filestore
amsanghi Jun 17, 2024
22955cf
Merge branch 'master' into das-filestore
Tristan-Wilson Jun 17, 2024
bfa498d
Fix ExpirationPolicy now that there is expiry
Tristan-Wilson Jun 18, 2024
1c6bf10
Merge branch 'master' into das-filestore
Tristan-Wilson Jun 18, 2024
1f67c39
Add missed error return
Tristan-Wilson Jun 18, 2024
ff67965
Merge branch 'master' into das-filestore
Tristan-Wilson Jun 21, 2024
dde1672
Merge branch 'master' into das-filestore
Tristan-Wilson Jun 24, 2024
2afba3c
Merge branch 'master' into das-filestore
Tristan-Wilson Jun 25, 2024
e8ef4bc
Merge branch 'master' into das-filestore
Tristan-Wilson Jun 27, 2024
f3db12d
Merge branch 'master' into das-filestore
Tristan-Wilson Jul 2, 2024
b50d38a
Merge branch 'master' into das-filestore
Tristan-Wilson Jul 8, 2024
e8410c8
Merge branch 'master' into das-filestore
joshuacolvin0 Jul 9, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions das/das_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,9 @@ func testDASStoreRetrieveMultipleInstances(t *testing.T, storageType string) {
KeyDir: dbPath,
},
LocalFileStorage: LocalFileStorageConfig{
Enable: enableFileStorage,
DataDir: dbPath,
Enable: enableFileStorage,
DataDir: dbPath,
MaxRetention: DefaultLocalFileStorageConfig.MaxRetention,
},
LocalDBStorage: dbConfig,
ParentChainNodeURL: "none",
Expand Down Expand Up @@ -129,8 +130,9 @@ func testDASMissingMessage(t *testing.T, storageType string) {
KeyDir: dbPath,
},
LocalFileStorage: LocalFileStorageConfig{
Enable: enableFileStorage,
DataDir: dbPath,
Enable: enableFileStorage,
DataDir: dbPath,
MaxRetention: DefaultLocalFileStorageConfig.MaxRetention,
},
LocalDBStorage: dbConfig,
ParentChainNodeURL: "none",
Expand Down
6 changes: 5 additions & 1 deletion das/factory.go
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,11 @@ func CreatePersistentStorageService(
}

if config.LocalFileStorage.Enable {
s, err := NewLocalFileStorageService(config.LocalFileStorage.DataDir)
s, err := NewLocalFileStorageService(config.LocalFileStorage)
if err != nil {
return nil, nil, err
}
err = s.start(ctx)
if err != nil {
return nil, nil, err
}
Expand Down
Loading
Loading