Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fixes to "separate cached from call cost" #2430

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Minor fixes to "separate cached from call cost" #2430

merged 1 commit into from
Jun 25, 2024

Conversation

PlasmaPower
Copy link
Collaborator

This PR updates #2426 to update the comment as recommended by Ganesh, and also use program.version instead of params.Version even though they're currently required to be the same.

@PlasmaPower PlasmaPower requested a review from tsahee June 25, 2024 04:40
@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Jun 25, 2024
tsahee
tsahee approved these changes Jun 25, 2024
View reviewed changes
Copy link
Collaborator

@tsahee tsahee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tsahee tsahee merged commit e6168fc into arbos-31 Jun 25, 2024
8 checks passed
@tsahee tsahee deleted the init-charge-fixes branch June 25, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsahee tsahee tsahee approved these changes

Assignees
No one assigned
Labels
s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PlasmaPower @tsahee