Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: break down query logs #2443

Merged
merged 11 commits into from
Jul 12, 2024

Conversation

renlulu
Copy link
Contributor

@renlulu renlulu commented Jun 28, 2024

In practice, while using some rpc provider we might easily reach the query limit and get following error which prevent sequencer from advancing the rollup blocks (nodes):

INFO [06-28|06:34:11.221] rpc response                             method=eth_getLogs logId=33993 err="413 Request Entity Too Large: {\"jsonrpc\":\"2.0\",\"id\":33993,\"error\":{\"code\":-32614,\"message\":\"eth_getLogs is limited to a 10,000 range\"}}" result=null attempt=0 args="[{\"address\":[\"0x2eb0e377acc5ec7fd8587dc4511021c708047466\"],\"fromBlock\":\"0x385caa6\",\"toBlock\":\"0x385fb75\",\"topics\":[[\"0x4f4caa9e67fb994e349dd35d1ad0ce23053d4323f83ce11dc817b5435031d096\"],null,[\"0x76f1d4183bf7e09c7b7f73c97bc48d9fcff35932149007eebfd12ec56a66eb96\"]]}]"

so it might be good to introduce a query range parameter and breakdown the query according to it.

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Jun 28, 2024
@renlulu renlulu force-pushed the enhance/break-down-query branch 2 times, most recently from 57ce409 to 2db2a0b Compare June 29, 2024 03:16
@renlulu renlulu force-pushed the enhance/break-down-query branch from 2db2a0b to 40ff630 Compare July 2, 2024 01:44
staker/staker.go Outdated Show resolved Hide resolved
staker/staker.go Outdated Show resolved Hide resolved
staker/staker.go Outdated Show resolved Hide resolved
staker/rollup_watcher.go Outdated Show resolved Hide resolved
staker/staker.go Outdated Show resolved Hide resolved
Copy link
Member

@joshuacolvin0 joshuacolvin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshuacolvin0 joshuacolvin0 enabled auto-merge July 12, 2024 12:27
@joshuacolvin0 joshuacolvin0 merged commit b6562ef into OffchainLabs:master Jul 12, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design-approved s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants