Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NIT-2652] init: allow classic node exported data in db dir #2454

Merged

Conversation

gligneul
Copy link
Contributor

@gligneul gligneul commented Jul 3, 2024

This PR adds more files to the allowed list of files that can be present when initializing the database. I also moved this code to a separate function to add a unit test.

@gligneul gligneul self-assigned this Jul 3, 2024
@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Jul 3, 2024
Copy link
Member

@eljobe eljobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I especially like how readable the test cases are.

cmd/nitro/init.go Show resolved Hide resolved
cmd/nitro/init.go Show resolved Hide resolved
@joshuacolvin0 joshuacolvin0 merged commit e0516e3 into master Jul 8, 2024
11 of 12 checks passed
@joshuacolvin0 joshuacolvin0 deleted the gligneul/fix-init-with-classic-node-export-data branch July 8, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design-approved s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants