Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NIT-1330] Feed Client should log loud error when rate limited #2458

Merged
merged 4 commits into from
Jul 9, 2024
+4 −1
Merged

[NIT-1330] Feed Client should log loud error when rate limited #2458

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
75a88e3
Feed Client should log loud error when rate limited
amsanghi Jul 8, 2024
c128452
fix
amsanghi Jul 8, 2024
d742d12
Merge branch 'master' into relay
amsanghi Jul 9, 2024
c205b67
Changes based on PR comments
amsanghi Jul 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion broadcastclient/broadcastclient.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ import (

"github.com/ethereum/go-ethereum/log"
"github.com/ethereum/go-ethereum/metrics"

"github.com/offchainlabs/nitro/arbutil"
m "github.com/offchainlabs/nitro/broadcaster/message"
"github.com/offchainlabs/nitro/util/contracts"
Expand Down Expand Up @@ -292,6 +291,10 @@ func (bc *BroadcastClient) connect(ctx context.Context, nextSeqNum arbutil.Messa
return nil, err
}
if err != nil {
connectionRejectedError := &ws.ConnectionRejectedError{}
if errors.As(err, &connectionRejectedError) && connectionRejectedError.StatusCode() == 429 {
log.Error("rate limit exceeded, please run own local relay because too many nodes are connecting to feed from same IP address", "err", err)
}
return nil, fmt.Errorf("broadcast client unable to connect: %w", err)
}
if config.RequireChainId && !foundChainId {
Expand Down
Loading