feat: disable sequencer MaxTxDataSize check against sequencer inbox MaxDataSize when DA is enabled #2881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…axDataSize when DA is enabled currently when DA is enabled the batch poster MaxSize check against the sequencer inbox MaxDataSize is disabled. hoping for the same behavior on the sequencer MaxTxDataSize check so that we can increase an orbit chain's max transaction size when Anytrust is enabled. keeping the check of the sequencer MaxTxDataSize against the batchPoster MaxSize as i'm assuming this is needed even when using an alt DA. by doing this, we can theoretically increase the sequencer MaxTxDataSize to ~212KB(limited by another check in the sequencer logic against arbostypes.MaxL2MessageSize) provided that we also bump the batchPoster MaxSize appropriately. originally was going to create a new dangerous flag for the sequencer that would disable all of these checks. however, i think this is a potentially simpler fix as comparing the sequencer MaxTxDataSize with the sequencer inbox MaxDataSize is probably not needed when the Anytrust committment in the sequencer inbox is a small/fixed size. would greatly appreciate any details if this is not a correct assumption to make.
|
|
|
discussed on slack! closing in favor for #2885 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently when DA is enabled the batch poster MaxSize check against the sequencer inbox MaxDataSize is disabled. hoping for the same behavior on the sequencer MaxTxDataSize check so that we can increase an orbit chain's max transaction size when Anytrust is enabled.
keeping the check of the sequencer MaxTxDataSize against the batchPoster MaxSize as i'm assuming this is needed even when using an alt DA.
by doing this, we can theoretically increase the sequencer MaxTxDataSize to ~212KB(limited by another check in the sequencer logic against arbostypes.MaxL2MessageSize) provided that we also bump the batchPoster MaxSize appropriately.
originally was going to create a new dangerous flag for the sequencer that would disable all of these checks. however, i think this is a potentially simpler fix as comparing the sequencer MaxTxDataSize with the sequencer inbox MaxDataSize is probably not needed when the Anytrust commitment in the sequencer inbox is a small/fixed size. would greatly appreciate any details if this is not a correct assumption to make.
i'm still trying to get my local
nitrobuild behaving correctly so I can properly add unit tests inconfig_test.go.original discussion in Slack for context(in the #alchemy-arbitrum-raas channel): https://alchemyinsights.slack.com/archives/C06SZ7EKS2H/p1730259929195879