feat: support test tool binary version #13093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #13093 +/- ##
==========================================
+ Coverage 90.21% 90.23% +0.02%
==========================================
Files 581 583 +2
Lines 34871 35062 +191
Branches 6891 6844 -47
==========================================
+ Hits 31458 31638 +180
- Misses 1488 1492 +4
- Partials 1925 1932 +7
|
tecton
requested review from
adashen,
blackchoey,
frankqianms,
swatDong,
XiaofuHuang,
kuojianlu,
kimizhu,
jayzhang,
wenytang-ms and
Siglud
as code owners
XiaofuHuang
approved these changes
Jan 23, 2025
frankqianms
approved these changes
Jan 23, 2025
| @@ -7,7 +7,7 @@ | |||
| "request": "launch", | |||
| "url": "https://teams.microsoft.com/l/app/${{TEAMS_APP_ID}}?installAppPackage=true&webjoin=true&${account-hint}", | |||
| "presentation": { | |||
| "group": "1-Teams", | |||
There was a problem hiding this comment.
whether local debug or test tool is the 1st choice depends on the flag {{#enableTestToolByDefault}}, which depends on if the TTK is a pre-release or a stable release.
I think it's ok to merge this first. Let's make the change in another PR.
There was a problem hiding this comment.
I'll check with you offline. Thanks.
jayzhang
approved these changes
Jan 24, 2025
huimiu
pushed a commit
that referenced
this pull request
Jan 27, 2025
* feat: install action support binary test tool * fix: use npm as default option * fix: add ut * feat(template): make test tool default option in python template * fix: schema change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature: https://msazure.visualstudio.com/Microsoft%20Teams%20Extensibility/_workitems/edit/30149297
Other Python template changes will be in separate PR.