-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thirdweb V5 Migration : SAN (Citizen Profile, Team Profile, Project Profile, Jobs, Marketplace) #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to thirdwebV5-migration-ct
…to thirdwebV5-migration-ct
✅ Deploy Preview for moondao-ce-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
❌ Deploy Preview for moondao-stc failed. Why did it fail? →
|
namedotget
changed the title
Thirdweb V5 Migration : SAN (Citizen Profile, Team Profile, Project Profile, Jobs, Marketplace)
Thirdweb V5 Migration : SAN (Citizen Profile, Team Profile, Project Profile, Jobs, Marketplace) ... will split into separate PRs
Jan 15, 2025
]) | ||
const isAddressManager: any = await readContract({ | ||
contract: teamContract, | ||
method: 'isManager' as string, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we always need the "as string"?
why?
jaderiverstokes
approved these changes
Jan 15, 2025
namedotget
changed the title
Thirdweb V5 Migration : SAN (Citizen Profile, Team Profile, Project Profile, Jobs, Marketplace) ... will split into separate PRs
Thirdweb V5 Migration : SAN (Citizen Profile, Team Profile, Project Profile, Jobs, Marketplace)
Jan 15, 2025
jaderiverstokes
approved these changes
Jan 15, 2025
namedotget
added a commit
that referenced
this pull request
Jan 17, 2025
…rofile, Jobs, Marketplace) (#309) * Started upgrading citizen profile to thirdweb v5 * Updated privy and safe deps * Upgraded safe * Upgraded privy provider * Configured PrivyWeb3Button to work with both thirdweb v4 & v5 * Migrated citizen profile to thirdweb v5 * Upgraded privy provider * Configured providers and hooks for thirdweb v5 * Migrated team and project profiles to thirdweb v5" * Migrated jobs page to thirdweb v5 * Migrated marketplace page to thirdweb v5 * Cleanup and finished migrating citizen profile to thirdweb v5 * Cleanup and finished migrating team profile to thirdweb v5 * Cleanup and finished migrating project profile to thirdweb v5 * Removed unused file * Adjusted requiredChain check * Relocated account check * Migrated tests to thirdweb v5 * Removed unused import * Added check for hats.forEach * Migrated projects page to thirdweb v5 * Removed comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.