Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSSTUDIO-2332: update beta log details ux #149

Merged
merged 1 commit into from
May 21, 2024
Merged

Conversation

cjenkscybercom
Copy link
Contributor

Summary of Changes

  • Makes the accordion / log details header more compact; only has author, created date, and attachments
  • Moves rest of the metadata info to the bottom (logbooks, tags, EntryType)

With many replies:
Screenshot 2024-05-20 at 11 30 16

With no replies:
Screenshot 2024-05-20 at 11 30 28

Visual Inspection

  • Conformance to Markdown styles: https://olog.esss.lu.se/Olog/help/CommonmarkCheatsheet
    • ...when viewing a log entry
    • ...when previewing HTML while writing a description
    • ...when viewing a log entry in the group view
  • Scroll is possible (elements don't overflow their container, and they are scrollable)
    • ...search result list
    • ...log entry group view list
    • ...log entry single view
    • ...create new log entry page
  • Overall layout fills full width and height of viewport
  • Pagination element doesn't overflow into other elements

@cjenkscybercom
Copy link
Contributor Author

All tests pass locally; please ignore flake

Copy link
Member

@georgweiss georgweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My guess would be logbooks and tags are more important than properties, so these should maybe be rendered on top of the accordions.
Also suggesting accordions are collapsed my default.
Then I'd suggest some margin/padding between rows in the meta-data section as shown in attached screen shot.
Screenshot 2024-05-20 at 13 35 22

@cjenkscybercom cjenkscybercom self-assigned this May 20, 2024
@cjenkscybercom
Copy link
Contributor Author

cjenkscybercom commented May 20, 2024

My guess would be logbooks and tags are more important than properties, so these should maybe be rendered on top of the accordions. Also suggesting accordions are collapsed my default. Then I'd suggest some margin/padding between rows in the meta-data section as shown in attached screen shot. Screenshot 2024-05-20 at 13 35 22

Let's ask for direct feedback on the placement of logbooks and tags w.r.t. entrytype when we refine this with ops. I kept the order/priority the same as it is in the current UI.
Screenshot 2024-05-20 at 13 50 30

Also, generally the theme of the ticket was making things more compact and that the accordion behavior would not be changed. Could you please verify against the agreed-upon deliverables in the ticket, thanks!

@georgweiss
Copy link
Member

So I checked against CSSTUDIO-2232, and I cannot find that it gainsays my feedback.
Isn't current accordion behavior collapsed by default, but expanded state maintained when switching to another entry?

@cjenkscybercom
Copy link
Contributor Author

cjenkscybercom commented May 20, 2024

So I checked against CSSTUDIO-2232, and I cannot find that it gainsays my feedback. Isn't current accordion behavior collapsed by default, but expanded state maintained when switching to another entry?

The deliverable was to not change the accordion behavior-- so I've left it as-is. If we decide to change that then let's please consider that as a separate piece of work, thank you.

The current behavior is:

  • only show the accordion when there is a group
  • when clicking an entry, then that entry's accordion is expanded and the others collapsed

@cjenkscybercom cjenkscybercom merged commit fbb6b6b into main May 21, 2024
3 of 6 checks passed
@cjenkscybercom cjenkscybercom deleted the CSSTUDIO-2332 branch May 21, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants