fix: set host vars in docker compose #194
Conversation
docker-compose.yml
Outdated
| @@ -9,6 +9,10 @@ services: | |||
| depends_on: | |||
| - mongo | |||
| - elastic | |||
| environment: | |||
| cors.allowed.origins: http://localhost:3000 | |||
There was a problem hiding this comment.
It is reasonable to have mongo.host and elasticsearch.network.host environment properties in docker compose file.
But it is not reasonable to have cors environment property there when reason is for localhost value. Have local docker compose file for such purpose. Git ignore container docker-compose-local* which means that you can have local docker compose file named docker-compose-local.yml for such purpose.
In addition, mongo.host and elasticsearch.network.host environment properties are missing from docker-compose-integrationtest-yml.
Please adjust.
Otherwise it's fine!
There was a problem hiding this comment.
Sure, can do.
Though I'll note having tried this that it appears the OlogIT etc tests don't appear to run successfully regardless and I don't see them running in the CI/CD here?
So that at least I think should be addressed separately. But at least given how the tests are run, using the same args in the integration tests seems reasonable.
Except cors allowed origins 🤦
I realized upon inspection that it already defaults to localhost:3000 in the java configuration files when the value is unset.
When starting the ecosystem / services with docker compose, the backend fails to communicate with elastic and mongo db.
This is because in the compose networking environment the service hosts are the names of the services (elastic, mongo, etc) rather than localhost.
This fixes that configuration issue for local development, and also adds localhost:3000 as an allowed cors origin so that local frontend development can speak to the server as well.