Fix cpp-linter workflow to avoid CUDA/HIP failures #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cpp-linter Review
Used clang-tidy v18.1.3
Click here for the full clang-tidy patch
diff --git a/lib/JitEngineDevice.hpp b/lib/JitEngineDevice.hpp
index 1020c8a..57e117a 100644
--- a/lib/JitEngineDevice.hpp
+++ b/lib/JitEngineDevice.hpp
@@ -468 +468 @@ void JitEngineDevice<ImplT>::specializeIR(Module &M, StringRef FnName,
- for (int i = 0; i < 10; i += 2)
+ for (int I = 0; I < 10; I += 2)
Used clang-format v18.1.3
No concerns from clang-format.
Have any feedback or feature suggestions? Share it here.
There was a problem hiding this comment.
Cpp-linter Review
Used clang-tidy v18.1.3
Click here for the full clang-tidy patch
diff --git a/lib/JitEngineDevice.hpp b/lib/JitEngineDevice.hpp
index 1020c8a..57e117a 100644
--- a/lib/JitEngineDevice.hpp
+++ b/lib/JitEngineDevice.hpp
@@ -468 +468 @@ void JitEngineDevice<ImplT>::specializeIR(Module &M, StringRef FnName,
- for (int i = 0; i < 10; i += 2)
+ for (int I = 0; I < 10; I += 2)
Used clang-format v18.1.3
No concerns from clang-format.
Have any feedback or feature suggestions? Share it here.
There was a problem hiding this comment.
Cpp-linter Review
Used clang-tidy v18.1.3
Click here for the full clang-tidy patch
diff --git a/lib/JitEngineDevice.hpp b/lib/JitEngineDevice.hpp
index 1020c8a..57e117a 100644
--- a/lib/JitEngineDevice.hpp
+++ b/lib/JitEngineDevice.hpp
@@ -468 +468 @@ void JitEngineDevice<ImplT>::specializeIR(Module &M, StringRef FnName,
- for (int i = 0; i < 10; i += 2)
+ for (int I = 0; I < 10; I += 2)
Used clang-format v18.1.3
No concerns from clang-format.
Have any feedback or feature suggestions? Share it here.
There was a problem hiding this comment.
Cpp-linter Review
Used clang-tidy v18.1.3
Click here for the full clang-tidy patch
diff --git a/lib/JitEngineDevice.hpp b/lib/JitEngineDevice.hpp
index 1020c8a..57e117a 100644
--- a/lib/JitEngineDevice.hpp
+++ b/lib/JitEngineDevice.hpp
@@ -468 +468 @@ void JitEngineDevice<ImplT>::specializeIR(Module &M, StringRef FnName,
- for (int i = 0; i < 10; i += 2)
+ for (int I = 0; I < 10; I += 2)
Used clang-format v18.1.3
No concerns from clang-format.
Have any feedback or feature suggestions? Share it here.
There was a problem hiding this comment.
Cpp-linter Review
Used clang-tidy v18.1.3
Click here for the full clang-tidy patch
diff --git a/lib/JitEngineDevice.hpp b/lib/JitEngineDevice.hpp
index 1020c8a..57e117a 100644
--- a/lib/JitEngineDevice.hpp
+++ b/lib/JitEngineDevice.hpp
@@ -468 +468 @@ void JitEngineDevice<ImplT>::specializeIR(Module &M, StringRef FnName,
- for (int i = 0; i < 10; i += 2)
+ for (int I = 0; I < 10; I += 2)
Used clang-format v18.1.3
No concerns from clang-format.
Have any feedback or feature suggestions? Share it here.
There was a problem hiding this comment.
Cpp-linter Review
Used clang-tidy v18.1.3
Click here for the full clang-tidy patch
diff --git a/lib/JitEngineDevice.hpp b/lib/JitEngineDevice.hpp
index 1020c8a..57e117a 100644
--- a/lib/JitEngineDevice.hpp
+++ b/lib/JitEngineDevice.hpp
@@ -468 +468 @@ void JitEngineDevice<ImplT>::specializeIR(Module &M, StringRef FnName,
- for (int i = 0; i < 10; i += 2)
+ for (int I = 0; I < 10; I += 2)
Used clang-format v18.1.3
No concerns from clang-format.
Have any feedback or feature suggestions? Share it here.
There was a problem hiding this comment.
Cpp-linter Review
Used clang-tidy v18.1.3
Click here for the full clang-tidy patch
diff --git a/lib/JitEngineDevice.hpp b/lib/JitEngineDevice.hpp
index 1020c8a..57e117a 100644
--- a/lib/JitEngineDevice.hpp
+++ b/lib/JitEngineDevice.hpp
@@ -468 +468 @@ void JitEngineDevice<ImplT>::specializeIR(Module &M, StringRef FnName,
- for (int i = 0; i < 10; i += 2)
+ for (int I = 0; I < 10; I += 2)
Used clang-format v18.1.3
No concerns from clang-format.
Have any feedback or feature suggestions? Share it here.
There was a problem hiding this comment.
Cpp-linter Review
Used clang-tidy v18.1.3
Click here for the full clang-tidy patch
diff --git a/lib/JitEngineDevice.hpp b/lib/JitEngineDevice.hpp
index 1020c8a..57e117a 100644
--- a/lib/JitEngineDevice.hpp
+++ b/lib/JitEngineDevice.hpp
@@ -468 +468 @@ void JitEngineDevice<ImplT>::specializeIR(Module &M, StringRef FnName,
- for (int i = 0; i < 10; i += 2)
+ for (int I = 0; I < 10; I += 2)
Used clang-format v18.1.3
No concerns from clang-format.
Have any feedback or feature suggestions? Share it here.
ggeorgakoudis
force-pushed
the
fix-cpp-linter
branch
from
f434181 to
3deed43
Compare
There was a problem hiding this comment.
Cpp-linter Review
Used clang-tidy v18.1.3
No concerns from clang-tidy.
Used clang-format v18.1.3
Click here for the full clang-format patch
diff --git a/lib/JitEngineDevice.hpp b/lib/JitEngineDevice.hpp
index a8f54fa..626d1e5 100644
--- a/lib/JitEngineDevice.hpp
+++ b/lib/JitEngineDevice.hpp
@@ -717 +717,2 @@ std::unique_ptr<Module> JitEngineDevice<ImplT>::linkJitModule(
- }return LinkedModule;
+ }
+ return LinkedModule;
Have any feedback or feature suggestions? Share it here.
- Keep clang-tidy review but do not fail due to compilation errors
ggeorgakoudis
force-pushed
the
fix-cpp-linter
branch
from
3deed43 to
927a6f0
Compare
ggeorgakoudis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.