Refactor to provide a core external interface #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ggeorgakoudis
commented
Feb 13, 2025
ggeorgakoudis
commented
- Support for Mneme
- Support for Mneme
koparasy
reviewed
Feb 13, 2025
| #include "proteus/CoreLLVMCUDA.hpp" | ||
| #endif | ||
|
|
||
| namespace proteus { |
There was a problem hiding this comment.
Some previous functionality is under detail namespace.
There was a problem hiding this comment.
Yes, I put in detail functions that called from the proteus namespace functions as "implementation", not expected as an external interface. Are you using them from Mneme?
koparasy
reviewed
Feb 13, 2025
| #ifndef PROTEUS_ERROR_H | ||
| #define PROTEUS_ERROR_H | ||
|
|
||
| #define FATAL_ERROR(x) \ |
There was a problem hiding this comment.
Maybe PROTEUS_FATAL_ERROR
koparasy
approved these changes
Feb 13, 2025
|
I don't see this function in this interface: |
|
@ggeorgakoudis I don't see the InitLLVM static function. Is this on purpose? |
ggeorgakoudis
changed the title
No, omission. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.