Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CPU lambda capture specialization #35

Merged
merged 12 commits into from
Dec 12, 2024
Merged

Conversation

davidbeckingsale
Copy link
Collaborator

Fixes #18

pass/ProteusPass.cpp Outdated Show resolved Hide resolved
Copy link
Collaborator

@ggeorgakoudis ggeorgakoudis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, moving to the right direction. I left some early comments.

lib/CMakeLists.txt Show resolved Hide resolved
lib/CompilerInterfaceHost.cpp Outdated Show resolved Hide resolved
lib/JitEngineHost.cpp Outdated Show resolved Hide resolved
lib/JitEngineHost.cpp Outdated Show resolved Hide resolved
lib/jit.hpp Outdated Show resolved Hide resolved
pass/ProteusPass.cpp Outdated Show resolved Hide resolved
pass/ProteusPass.cpp Outdated Show resolved Hide resolved
pass/ProteusPass.cpp Outdated Show resolved Hide resolved
tests/cpu/lambda.cpp Outdated Show resolved Hide resolved
pass/ProteusPass.cpp Outdated Show resolved Hide resolved
@davidbeckingsale davidbeckingsale force-pushed the feature/jit-lambda-capture branch from f27f717 to d5a9859 Compare November 26, 2024 18:27
@davidbeckingsale davidbeckingsale force-pushed the feature/jit-lambda-capture branch from 9bfce7c to 2308fbe Compare December 5, 2024 23:54
@davidbeckingsale davidbeckingsale marked this pull request as ready for review December 5, 2024 23:55
@davidbeckingsale davidbeckingsale changed the title Add lambda capture specialization Add CPU lambda capture specialization Dec 6, 2024
lib/CMakeLists.txt Outdated Show resolved Hide resolved
pass/ProteusPass.cpp Outdated Show resolved Hide resolved
scripts/setup-lassen.sh Outdated Show resolved Hide resolved
lib/TransformLambdaSpecialization.hpp Outdated Show resolved Hide resolved
pass/ProteusPass.cpp Outdated Show resolved Hide resolved
lib/JitVariable.hpp Show resolved Hide resolved
lib/TransformLambdaSpecialization.hpp Show resolved Hide resolved
int Slot = CI->getZExtValue();
for (auto Arg : RC) {
if (Arg.Slot == Slot) {
LoadInst *LI = dyn_cast<LoadInst>(*(User->users().begin()));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We assume that there is a single Load user of the GEP, but there can be multiple. Iterate over all Load instructions users.

pass/ProteusPass.cpp Show resolved Hide resolved
pass/ProteusPass.cpp Outdated Show resolved Hide resolved
@ggeorgakoudis ggeorgakoudis force-pushed the feature/jit-lambda-capture branch from d9ab588 to 30a5986 Compare December 10, 2024 01:03
@ggeorgakoudis
Copy link
Collaborator

Rebase ☝️

@ggeorgakoudis ggeorgakoudis merged commit 274ed63 into main Dec 12, 2024
12 checks passed
@ggeorgakoudis ggeorgakoudis deleted the feature/jit-lambda-capture branch December 12, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend proteus for RAJA lambda capture specialization 1
3 participants