Fix performance regression for device compileAndRun #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Extract runtime constant types in the pass - Avoid bitcode parsing unless compiling - Link binaries for CUDA RDC in object codegen - Add kernel repeat test
ggeorgakoudis
requested review from
davidbeckingsale,
johnbowen42 and
tbennun
johnbowen42
approved these changes
Dec 12, 2024
| namespace proteus { | ||
|
|
||
| enum RuntimeConstantTypes : int32_t { | ||
| BOOL = 1, |
There was a problem hiding this comment.
This is a great addition, I should've done this in the first place
| @@ -14,6 +14,19 @@ | |||
| #include <cstring> | |||
| #include <stdint.h> | |||
|
|
|||
| namespace proteus { | |||
|
|
|||
| enum RuntimeConstantTypes : int32_t { | |||
There was a problem hiding this comment.
why inherit from, int32_t, just to enforce size?
There was a problem hiding this comment.
Yes, to match the expected data type from the pass
| auto getNumRCs() const { return NumRCs; } | ||
| JITKernelInfo(char const *Name, int32_t *RCIndices, int32_t *RCTypes, | ||
| int32_t NumRCs) | ||
| : Name(Name), RCIndices{ArrayRef{RCIndices, static_cast<size_t>(NumRCs)}}, |
There was a problem hiding this comment.
nice use of the constructors here
tbennun
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #59