Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Logger for file output logs #66

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Conversation

ggeorgakoudis
Copy link
Collaborator

@ggeorgakoudis ggeorgakoudis commented Dec 13, 2024

Store debug output in files

Closes #24

@ggeorgakoudis
Copy link
Collaborator Author

Rebase ☝️

@ggeorgakoudis ggeorgakoudis force-pushed the store-debug-output-in-log branch from 9865829 to 9bd2026 Compare December 13, 2024 15:18
@ggeorgakoudis
Copy link
Collaborator Author

Rebase ☝️

@davidbeckingsale
Copy link
Collaborator

I think you should add PID to the log filename to help differentiate when running multiprocess, or just running same binary over and over.

@davidbeckingsale
Copy link
Collaborator

Also maybe we could/should consider a third-party dependency for this: https://github.com/gabime/spdlog

@ggeorgakoudis
Copy link
Collaborator Author

ggeorgakoudis commented Dec 16, 2024

I think you should add PID to the log filename to help differentiate when running multiprocess, or just running same binary over and over.

@davidbeckingsale Does it work to open an issue for this? I intended this to be a very basic commit that just introduces the functionality to move from monitor printouts to a file, even if overwritten. This still serves the use-case of manual. visual inspecting where we run one compilation/execution and want to see the output.

@ggeorgakoudis
Copy link
Collaborator Author

Also maybe we could/should consider a third-party dependency for this: https://github.com/gabime/spdlog

@davidbeckingsale I wasn't aware of spdlog and it looks awesome! However, I'd like to keep dependencies to a minimum until we have a robust, well-integrated core. Can we again open an issue for forward development?

@ggeorgakoudis ggeorgakoudis merged commit 253df83 into main Dec 17, 2024
12 checks passed
@ggeorgakoudis ggeorgakoudis deleted the store-debug-output-in-log branch December 17, 2024 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement a unified logging interface
2 participants