-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Register proteus pass late #81
Conversation
Is there concern this will break any of our analysis/transformations? e.g. lambda specialization stuff looks for very specific patterns |
Thnx for pointing this out. You are right! It may, I have not checked the patterns we are currently "catching". Do we have tests for these patterns? |
Test programs yes, but no IR checking
|
this is a low priority PR, and I am still testing things out. Deciding on which stage we are going to run the pipeline is important and we should do it asap. In terms of performance, it makes more sense to register it late. |
I will take that back. It is possible to run the annotation analysis early in the pipeline, and the registering of the LLVM IR files late in the pipeline. This may give us both capabilities. |
If the GitLab passes then I'm not worried :) |
Passed :) |
An issue with late registration is that we may miss JIT annotated functions that have been inlined. We don't test for that, e.g., marking |
That's a good point |
Registers pass late as discussed in #79 .
Pending tasks: