Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register proteus pass late #81

Closed
wants to merge 1 commit into from
Closed

Conversation

koparasy
Copy link
Collaborator

@koparasy koparasy commented Dec 19, 2024

Registers pass late as discussed in #79 .

Pending tasks:

@davidbeckingsale
Copy link
Collaborator

Is there concern this will break any of our analysis/transformations? e.g. lambda specialization stuff looks for very specific patterns

@koparasy
Copy link
Collaborator Author

koparasy commented Dec 19, 2024

Is there concern this will break any of our analysis/transformations? e.g. lambda specialization stuff looks for very specific patterns

Thnx for pointing this out. You are right! It may, I have not checked the patterns we are currently "catching". Do we have tests for these patterns?

@davidbeckingsale
Copy link
Collaborator

davidbeckingsale commented Dec 19, 2024 via email

@koparasy
Copy link
Collaborator Author

this is a low priority PR, and I am still testing things out. Deciding on which stage we are going to run the pipeline is important and we should do it asap. In terms of performance, it makes more sense to register it late.

@koparasy
Copy link
Collaborator Author

I will take that back. It is possible to run the annotation analysis early in the pipeline, and the registering of the LLVM IR files late in the pipeline. This may give us both capabilities.

@davidbeckingsale
Copy link
Collaborator

If the GitLab passes then I'm not worried :)

@koparasy
Copy link
Collaborator Author

Passed :)

@ggeorgakoudis
Copy link
Collaborator

ggeorgakoudis commented Dec 19, 2024

An issue with late registration is that we may miss JIT annotated functions that have been inlined.

We don't test for that, e.g., marking always_inline a JIT-annotated function.

@koparasy
Copy link
Collaborator Author

That's a good point

@koparasy koparasy closed this Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants