fix: Stop defaulting to black in framebox package #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It might have a bug (though I don't see it when printing the graphics path out), or just be too demanding: from time to time it crashes my PDF viewer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The framebox package defaults to black when some color arguments to commands are not specified.
It should not be the case, in order to just use the default/current color at that point.
The issue also has to do with our DefaultPainter having a slightly different API than the RoughPainter: the latter admits "none" as a fill or stroke, wheras the former did not. Let's make a first attempt at homogenizing the low-level APIs there.