[Refactor]: UserContext 수정 및 적용 #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
kimjm9841
approved these changes
Mar 4, 2024
| @@ -20,18 +21,21 @@ | |||
| public class FeedServiceImpl implements FeedService { | |||
|
|
|||
| private final FeedRepository feedRepository; | |||
| private final UserService userService; | |||
There was a problem hiding this comment.
리포지토리 말고 서비스를 호출한 이유가 있을까용?
There was a problem hiding this comment.
수정한 테스트는 이제 순환참조 오류 안뜨고 성공하고, 리파지토리에 대한 의존성을 직접 가지는 것보다는 이미 그 리파지토리를 활용한 서비스에 의존하는게 더 좋은 구조라고 생각해서 그렇게 뒀습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
🎋 작업중인 브랜치
💡 작업동기
🔑 주요 변경사항
💡 관련 이슈
x