Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: docker image build and validation checks #39

Merged
merged 1 commit into from
Feb 23, 2024
Merged

feat: docker image build and validation checks #39

merged 1 commit into from
Feb 23, 2024

Conversation

Altonhe
Copy link
Member

@Altonhe Altonhe commented Feb 22, 2024

As #19 mentioned, this repo needs CI support, this PR added two workflows for the repo:

  • Test docker image build
  • Use validate.sh to make sure everything works right

@Altonhe
feat: add build test for docker image (#1)
52dae80 
* feat: add build test for docker image
@CLAassistant
Copy link

CLAassistant commented Feb 22, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

aaronbrethorst
aaronbrethorst approved these changes Feb 23, 2024
View reviewed changes
Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thank you! 💯

@aaronbrethorst aaronbrethorst merged commit a0f204d into OneBusAway:main Feb 23, 2024
3 checks passed
@aaronbrethorst aaronbrethorst mentioned this pull request Feb 23, 2024
Closed
@Altonhe Altonhe deleted the feature/githubci branch February 26, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronbrethorst aaronbrethorst aaronbrethorst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Altonhe @CLAassistant @aaronbrethorst