Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1066 Fix: Target Android 11 (API Level 30) #1085

Closed
wants to merge 1 commit into from

Conversation

hubertgoeuropa
Copy link

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Apply the AndroidStyle.xml style template to your code in Android Studio.

  • Run the unit tests with gradlew connectedObaGoogleDebugAndroidTest connectedObaAmazonDebugAndroidTest to make sure you didn't break anything

  • If you have multiple commits please combine them into one commit by squashing them for the initial submission of the pull request. When addressing comments on a pull request, please push a new commit per comment when possible (reviewers will squash and merge using GitHub merge tool)

@barbeau
Copy link
Member

barbeau commented Jan 17, 2022

Thanks @hubertgoeuropa for opening this!

Could you say a little more about the different cases mentioned in #1066 and if you've tested them? For example, for scoped storage, did you test backup and restore on devices before and after Android 11?

@barbeau
Copy link
Member

barbeau commented Jan 17, 2022

Also, I see this changes minSdkVersion from 16 to 19. Why is that needed?

@barbeau
Copy link
Member

barbeau commented May 10, 2022

@hubertgoeuropa Thanks for opening this. Due to Google's ongoing requirement changes I'm going to go ahead and directly target API Level 31, so I'm closing this in favor of PR #1087.

@barbeau barbeau closed this May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants