-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yili - Gives the user permission to Reset and/or Change the password of any user #1146
base: development
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly good. Just remove it from Admins and I'll approve.
remove resetPassword from Admin
remove resetPassword from Admin in test permissions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Frontend function as expected, fix minor issue in the backend before merging.
@@ -487,14 +490,14 @@ const userProfileController = function (UserProfile, Project) { | |||
} | |||
// validate userprofile pic | |||
|
|||
if (req.body.profilePic) { | |||
const results = userHelper.validateProfilePic(req.body.profilePic); | |||
// if (req.body.profilePic) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove commented out code before merging.
Description
Related PRS
To test this backend PR you need to checkout the frontend PR #2860
How to test: