Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yili - Gives the user permission to Reset and/or Change the password of any user #1146

Open
wants to merge 3 commits into
base: development
Choose a base branch
from

Conversation

suaniii
Copy link

@suaniii suaniii commented Nov 12, 2024

Description

Gives the user permission to Reset and:or Change the password of any user but Owner:Admin classes

Related PRS

To test this backend PR you need to checkout the frontend PR #2860

How to test:

  1. check into current branch
  2. do npm install and ... to run this PR locally
  3. follow the steps on the frontend PR #2860

Copy link
Contributor

@nathanah nathanah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good. Just remove it from Admins and I'll approve.

src/utilities/createInitialPermissions.js Outdated Show resolved Hide resolved
src/test/createTestPermissions.js Outdated Show resolved Hide resolved
remove resetPassword from Admin
remove resetPassword from Admin in test permissions
Copy link

@honglinchen0524 honglinchen0524 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Frontend function as expected, fix minor issue in the backend before merging.

@@ -487,14 +490,14 @@ const userProfileController = function (UserProfile, Project) {
}
// validate userprofile pic

if (req.body.profilePic) {
const results = userHelper.validateProfilePic(req.body.profilePic);
// if (req.body.profilePic) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove commented out code before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants