Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ashish_Fix_Rehireable_Status #1148

Merged
merged 1 commit into from
Dec 14, 2024
Merged

Conversation

AshishNags
Copy link
Contributor

@AshishNags AshishNags commented Nov 13, 2024

Description

image

Related PRS (if any):

This PR is related to the Frontend PR# 2866

Main changes explained:

  • Update canRequestorUpdateUser in src\utilities\permissions.js to convert _ids to strings

How to test:

  1. check into current branch
  2. do npm install and ... to run this PR locally
  3. Clear site data/cache
  4. log as admin user
  5. Follow steps on Frontend PR 2866.

Screenshots or videos of changes:

Screenshot 2024-11-08 224731

Note:

Include the information the reviewers need to know.

@AshishNags AshishNags changed the title updated canRequestorUpdateUser function to convert _id to string Ashish_Fix_Rehireable_Status Nov 13, 2024
Copy link

@nikhilpittala16 nikhilpittala16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested the PR and everything works as expected. left a review on Front-end

Copy link

@anji-annavarapu anji-annavarapu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HGN.APP.-.Google.Chrome.2024-11-16.23-54-02.mp4

its as expected and everything good

@one-community
Copy link
Member

Thank you all, merging!

@one-community one-community merged commit b4966b1 into development Dec 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants